Cheshire Cat Computing

Sorry , Even with rrdtools-1.3.6 the error persists .
I have even place a line in routers.conf with 'maxtitle=' at both 128 & 64 and t3ested each seperately , the error persisted even with these in place .

Fmi , Where in routers2.conf does the 'maxtitle=' belong , maybe I am just not getting it in the right place ?

Also I am wondering if I might have buggered up somewhere else ? an older package that need updating ?... But after checking the (well most of them anyway) I an within a sub-version of being the lastest on all packages mentioned in the

Tia , JimL

The maxtitle=64 should go in the [routers.cgi] section of the routers2.conf.

You're using one of the most recent of the 1.2 branch so I'm not sure whay this isnt helping. I might have to try and get my dev system to use the 1.2 package (I think it was 1.2.12 I last had here) and attempt to duplicate this. It would be good to know the real character limit for the title but I suspect it is a limitiation of the graphics library Tobi uses rather than a limit of RRDtool so it will be hard to work out.

There's also a possibility that the problem lies elsewhere and truncating the title doesnt help, but since you managed to fix things by shortening the title in the cfg file that probably isnt it (there didnt appear to be any unusual characters in the title that may have broken things, and in any case they'd have been escaped prior to the library call)

_________________
Steve Shipway
UNIX Systems, ITSS, University of Auckland, NZ
Woe unto them that rise up early in the morning... -- Isaiah 5:11

Hello Steve , Just a Fyi .
The special chars in the offending string are ...
'(' ';' ')' ','

all the rest are [:alnum:] .

What items creates the line below ? If I can find that I can trim the length myself .
tia , JimL

+- This portion .
vvvvvvvvvv
COMMENT:6 06 mo-eb01.dsb.local. (10.1.1.209;XXXXXX), mo-eb03.dsb.local. (10.1.1.211;XXXXXX), mo-eb02.dsb.local. (10.1.1.210;XXXXXX), mo-eb-prt01.dsb.local. (10.1.1.82;XXXXXX), mo-eb04.dsb.local. (10.1.1.208;XXXXXX),

This is added in usr_params at the start of the loop for the component Target, to give the title. I was under the impression that the only forbidden character in a COMMENT is the colon, brackets and so on are fine.

It is probably too long, though; I should make maxtitle also apply to this place (it is currently only applying to the graph title). I think this is probably the thing that still needs to be done, I will take a look today and try to get a beta out.

_________________
Steve Shipway
UNIX Systems, ITSS, University of Auckland, NZ
Woe unto them that rise up early in the morning... -- Isaiah 5:11

_________________
Steve Shipway
UNIX Systems, ITSS, University of Auckland, NZ
Woe unto them that rise up early in the morning... -- Isaiah 5:11

Hello Steve ,

[quote="stevesh"]I now have a fix that seems to work (still testing). This is from the usr_params subroutine:
(At the start)

I found 'my($titlemaxlen)' in 'sub make_graph(@)' at ~ line 5857 in 2.20B4 and added the changes to the file .

[code] my($titlemaxlen) = 128;
$titlemaxlen = $config{'routers.cgi-maxtitle'}?$config{'routers.cgi-maxtitle'}:128;
[/code]
(Further down)

I found 'if($mirroring and $lin and $lout )' at ~ line 4858 in 2.20B4 and added the changes to the file .
note: after the changes made above .

[code] if($mirroring and $lin and $lout ) {
$lout = "";
$lin = $interfaces{$curif}{desc};
$lin = substr($lin,0,$titlemaxlen) if(length($lin)>$titlemaxlen);
$lin =~ s/:/\\:/g;
$lin = ":$lin\\l";
} else {
if( !$interfaces{$interface}{nolegend} and
!$interfaces{$interface}{nodetails} and
!$interfaces{$interface}{nodesc} and
$dwmy !~ /s/ and
!$interfaces{$interface}{noi} and
!$interfaces{$interface}{noo}) {
my($tmpt) = $interfaces{$curif}{desc};
$tmpt = substr($tmpt,0,$titlemaxlen)
if(length($tmpt)>$titlemaxlen);
push @params, "COMMENT:".decolon("$tmpt:\\l");
}
}
[/code][/quote]

I then receive this ...

[quote]
Internal Server Error

The server encountered an internal error or misconfiguration and was unable to complete your request.

Please contact the server administrator, you@example.com and inform them of the time the error occurred, and anything you might have done that may have caused the error.

More information about this error may be available in the server error log.
[/quote]

And this in /var/log/http/error_log

[quote]
[Wed Feb 18 16:52:19 2009] [error] [client 10.1.1.169] Global symbol "$titlemaxlen" requires explicit package name at /var/www/cgi-bin/routers2.cgi line 4864.
[Wed Feb 18 16:52:19 2009] [error] [client 10.1.1.169] Global symbol "$titlemaxlen" requires explicit package name at /var/www/cgi-bin/routers2.cgi line 4864.
[Wed Feb 18 16:52:19 2009] [error] [client 10.1.1.169] Global symbol "$titlemaxlen" requires explicit package name at /var/www/cgi-bin/routers2.cgi line 4875.
[Wed Feb 18 16:52:19 2009] [error] [client 10.1.1.169] Global symbol "$titlemaxlen" requires explicit package name at /var/www/cgi-bin/routers2.cgi line 4876.
[Wed Feb 18 16:52:19 2009] [error] [client 10.1.1.169] Execution of /var/www/cgi-bin/routers2.cgi aborted due to compilation errors.
[Wed Feb 18 16:52:19 2009] [error] [client 10.1.1.169] Premature end of script headers: routers2.cgi
[/quote]

So it seems I have misentered somethign but I sure don't see it .
See the attached diff to see if I did it right .
Hth , JimL[attachment=0]routers2_cgi-diffs-20090218.txt[/attachment]

Both code snippets should have been added to usr_params, the first (short) one at the beginning of the function. That's why its failing.
I'll post a beta soon, but no time today . Maybe Monday

_________________
Steve Shipway
UNIX Systems, ITSS, University of Auckland, NZ
Woe unto them that rise up early in the morning... -- Isaiah 5:11

Hello Steve , Thank you for correcting me as to where the changes needed to be inserted .
Beta??? whenever you can/feel like it/feel it is time .
Tnx , JimL

How feasible would it be to have a "max-comment=" item as well ? Since it appears that that entity is what was causing the latest set of problems .
I would like to present as much data to my support people as possible & If I can get away with a much longer "max-title" than "max-comment" I would really like to .
Tia , JimL